Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDBs to windows distribution #4991

Open
myk002 opened this issue Oct 7, 2024 · 2 comments
Open

Add PDBs to windows distribution #4991

myk002 opened this issue Oct 7, 2024 · 2 comments

Comments

@myk002
Copy link
Member

myk002 commented Oct 7, 2024

  • add /Zi to the compile flags
  • add /DEBUG to the link flags

and package where?

@ab9rf
Copy link
Member

ab9rf commented Oct 7, 2024

just store the PDBs as a build artifact, they do not need to be sent to subscribers; mostly in order to usefully diagnose crash reports i need to have a PDB that exactly matches the executable the user is using; that is, it was generated by the same compilation run as the executable was

there's no real harm in packaging the pdb into the distribution (and in fact there might be some benefit in doing so) but they will make it larger

@lethosor
Copy link
Member

lethosor commented Oct 8, 2024

We used to do this on Buildmaster and just kept the artifacts separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants