Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change link text instead of adding labels on my account #948

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Change link text instead of adding labels on my account #948

merged 2 commits into from
Nov 8, 2023

Conversation

peterdavidhamilton
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton commented Nov 8, 2023 •
edited
Loading

@peterdavidhamilton peterdavidhamilton added this to the rc0.12.1 milestone Nov 8, 2023
@peterdavidhamilton peterdavidhamilton added the review Review app deployed to Azure label Nov 8, 2023
@viezly viezly
Copy link

viezly bot commented Nov 8, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

jack-coggin
jack-coggin reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jack-coggin jack-coggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterdavidhamilton Should this text be added to the localisations?

@peterdavidhamilton
Copy link
Contributor Author

@peterdavidhamilton Should this text be added to the localisations?

Absolutely right to pull me on that @jack-coggin. I have arranged a ticket to attack all remaining hardcoded text in one go to give complete autonomy to the Content team. This ticket has a 6th AC that can't be satisfied yet so I know we are returning here soon enough.

Does that excuse work? 😉

@jack-coggin
Copy link
Contributor

@peterdavidhamilton Should this text be added to the localisations?

Absolutely right to pull me on that @jack-coggin. I have arranged a ticket to attack all remaining hardcoded text in one go to give complete autonomy to the Content team. This ticket has a 6th AC that can't be satisfied yet so I know we are returning here soon enough.

Does that excuse work? 😉

I'll let it pass for now @peterdavidhamilton 😂

@peterdavidhamilton peterdavidhamilton added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit 155eb94 Nov 8, 2023
2 of 3 checks passed
@peterdavidhamilton peterdavidhamilton deleted the my-account-links branch November 8, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-coggin jack-coggin jack-coggin approved these changes

@instantrick instantrick Awaiting requested review from instantrick

Assignees
No one assigned
Labels
review Review app deployed to Azure
Projects
None yet
Milestone
v0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdavidhamilton @jack-coggin