From 666104283546293a12e5ff4a25cf19bb725a9b57 Mon Sep 17 00:00:00 2001 From: "jack.coggin" Date: Mon, 11 Sep 2023 08:41:08 +0100 Subject: [PATCH] division fix for high fail questions data model --- app/models/data/high_fail_questions.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/data/high_fail_questions.rb b/app/models/data/high_fail_questions.rb index 0e93fd13f..795dc3c2e 100644 --- a/app/models/data/high_fail_questions.rb +++ b/app/models/data/high_fail_questions.rb @@ -48,10 +48,10 @@ def high_fail_questions question_failures.each do |(module_name, question_name), fail_count| total_count = question_attempts[[module_name, question_name]] - fail_rate = fail_count / total_count + fail_rate = fail_count / total_count.to_f if fail_rate >= average_fail_rate - high_fail_questions[[module_name, question_name]] = fail_rate.to_f + high_fail_questions[[module_name, question_name]] = fail_rate end end