Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Stale arduino-cli process stops the installer from proceeding #175

Closed
peteGSX opened this issue Jun 20, 2024 · 1 comment
Closed
Labels
Bug Something isn't working as designed EX-Installer Item relates to EX-Installer

Comments

@peteGSX
Copy link
Contributor

peteGSX commented Jun 20, 2024

Version

0.0.19 (in development)

Bug description

When clicking the Refresh CLI button, a stale arduino-cli process seems to remain running for some time which appears to be checking the version as this is logged after all other activities in the debug log. This results in all controls being locked and the progress bar continuing to move, preventing a user from proceeding forwards or backwards.

Steps to reproduce the bug

Run the installer.
Navigate to the Manage the CLI window.
Click the Refresh CLI button quickly after navigating to this screen.

Expected behaviour

When navigating to this screen, the controls should all be locked until the version check has completed in the background, and then all controls should be enabled.

When then clicking the refresh button, all controls should be locked and the progress bar should move until all steps have completed, with the controls then being enabled and the progress bar stopping.

Screenshots

No response

Additional context

This has only happened since adjusting the event management method in the manage_arduino_cli.py module and moving from if/elif/else to match/case to make the logic simpler to follow.

@peteGSX peteGSX added the Bug Something isn't working as designed label Jun 20, 2024
@github-actions github-actions bot added the EX-Installer Item relates to EX-Installer label Jun 20, 2024
@dcc-ex-project-workflow-app dcc-ex-project-workflow-app bot moved this to To Do in DCC-EX Jun 20, 2024
@peteGSX
Copy link
Contributor Author

peteGSX commented Jun 22, 2024

Additional changes made to the arduino_cli module to cater for specifying the ESP32 version introduced an additional instance of a thread being created, meaning an Arduino CLI process was returning out of order and causing this issue to occur. Reverted to original behaviour plus dealing with the ESP32 version and all is now good.

@peteGSX peteGSX closed this as completed Jun 22, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in DCC-EX Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed EX-Installer Item relates to EX-Installer
Projects
Status: Done
Development

No branches or pull requests

1 participant