Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate use of Plane markup #19

Open
jcfr opened this issue Jun 4, 2020 · 2 comments
Open

Evaluate use of Plane markup #19

jcfr opened this issue Jun 4, 2020 · 2 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented Jun 4, 2020

To define a planes, the user is currently expected to:

  • click on "Compute around bounding box"
  • select the model for projection
  • create a "connected landmark list"
  • click "add a new plane"
  • manually place 3 fiducials and make sure the correct fiducials are associated with the plane

image

To streamline this process and rely on the new plane markups, here are few questions:

  • what is the role of the "Define middle point between two landmarks" ? Is this is still needed ?
  • the save/load plane is an undocumented format specific to this extension. Are these files used ? Can we now use the new "json" format used to save markup annotation in Slicer ? (it is versioned and has a schema)

The plane markup is also associated with 3 fiducials and provide a mechanism to easily adjust angle/origin of the plane by showing an interactive tool:

image

By using the plane annotation, we would remove a lot of code in the extension and would simply display a list of plane markup annotations.

cc: @msyatabe

@bpaniagua
Copy link

Bravo, JC!
cc: @luciacev

@jcfr
Copy link
Contributor Author

jcfr commented Jun 8, 2020

what is the role of the "Define middle point between two landmarks" ? Is this is still needed ?

Look like we could remove the middle point functionality from this extension as it is already part of https://github.com/DCBIA-OrthoLab/Q3DCExtension ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants