Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use #37

Open
wrunk opened this issue Sep 28, 2016 · 0 comments
Open

Don't use #37

wrunk opened this issue Sep 28, 2016 · 0 comments

Comments

@wrunk
Copy link

wrunk commented Sep 28, 2016

The project owner is no longer maintaining this and there are a number of issues. I suggest looking at: https://github.com/h2non/bimg
@hassox hassox mentioned this issue Aug 8, 2017
Merged
openskydoor pushed a commit to opendoor-labs/gothumb that referenced this issue Oct 4, 2017
@hassox
Move away from VIPS for bimg
f4e98c3 
We noticed that our images are being rotated in sherlock.

It seems that this is happening in gothumb (we have the original in the correct orientation)

Rather than try and work this out I found this issue. DAddYE/vips#37

What is concerning is that from the README

> When generating JPEG output all metadata is removed and Huffman tables optimised without having to use separate command line tools like jpegoptim and jpegtran.

I'm guessing at Go a bit so there's likely some unwanted changes in this :(
openskydoor pushed a commit to opendoor-labs/gothumb that referenced this issue Oct 8, 2017
@hassox
Move away from VIPS for bimg
6248665 
We noticed that our images are being rotated in sherlock.

It seems that this is happening in gothumb (we have the original in the correct orientation)

Rather than try and work this out I found this issue. DAddYE/vips#37

What is concerning is that from the README

> When generating JPEG output all metadata is removed and Huffman tables optimised without having to use separate command line tools like jpegoptim and jpegtran.

I'm guessing at Go a bit so there's likely some unwanted changes in this :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wrunk