Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SYSTEM to add_subdirectory calls for bundled libraries #2328

Open
cz4rs opened this issue Jul 16, 2024 · 0 comments
Open

add SYSTEM to add_subdirectory calls for bundled libraries #2328

cz4rs opened this issue Jul 16, 2024 · 0 comments

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Jul 16, 2024

CMake 3.25 introduces SYSTEM argument to add_subdirectory. Use that for all our bundled libraries to have them included with -isystem rather than -I.

https://cmake.org/cmake/help/latest/command/add_subdirectory.html

Tagging this with c++20 because we currently have cmake_minimum_required 3.23. We should be able to bump CMake requirements along with adopting new standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant