Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded minimal bound on average load in tempered LB #2220

Open
ppebay opened this issue Nov 27, 2023 · 1 comment
Open

Replace hard-coded minimal bound on average load in tempered LB #2220

ppebay opened this issue Nov 27, 2023 · 1 comment

Comments

@ppebay
Copy link
Contributor

ppebay commented Nov 27, 2023

What Needs to be Done?
The decision to do load-balancing in the tempered algorithm is currently constrained by hard-code minimum bound on average load (set at 1e-10).

Is your feature request related to a problem? Please describe.
There are no first principles justifying this and this could also result in incorrect decisions.
For example, object loads could be very small and result in a balance smaller (on average) than this hard-coded value -- while imbalance would nevertheless be high and warrant LB triggering.

Describe potential solution outcome
A replacement of this hard-coded value using first principles should be thought of, and implemented.

Describe alternatives you've considered

Additional context

@nlslatt
Copy link
Collaborator

nlslatt commented Nov 27, 2023

Given the extremely small magnitude, I suspect this was originally intended to avoid load balancing when there effectively was zero load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants