From 1e0716e756ed599a9471f7b4eb4f358b7ebbf8d0 Mon Sep 17 00:00:00 2001 From: Jacob Domagala Date: Thu, 5 Oct 2023 13:43:07 +0200 Subject: [PATCH] #2183: Make vt_ldms_includes/lib optional --- cmake/check_system_functions.cmake | 9 --------- cmake/link_vt.cmake | 24 ++++++++++++++++++------ 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/cmake/check_system_functions.cmake b/cmake/check_system_functions.cmake index c274bcfabd..14aa261bed 100644 --- a/cmake/check_system_functions.cmake +++ b/cmake/check_system_functions.cmake @@ -32,12 +32,3 @@ check_function_exists(sysinfo vt_has_sysinfo) set(CMAKE_REQUIRED_INCLUDES "mach/mach.h") check_function_exists(mach_task_self vt_has_mach_task_self) - -set(CMAKE_REQUIRED_INCLUDES "ldms/ldms.h") -check_function_exists(ldms_h vt_has_ldms_h) - -set(CMAKE_REQUIRED_INCLUDES "ldms/ldmsd_stream.h") -check_function_exists(ldmsd_stream_h vt_has_ldmsd_stream_h) - -set(CMAKE_REQUIRED_INCLUDES "ovis_util/util.h") -check_function_exists(ovis_util_h vt_has_ovis_util_h) diff --git a/cmake/link_vt.cmake b/cmake/link_vt.cmake index 3b9d602a09..654febd615 100644 --- a/cmake/link_vt.cmake +++ b/cmake/link_vt.cmake @@ -216,13 +216,25 @@ function(link_target_with_vt) if (${ARG_DEBUG_LINK}) message(STATUS "link_target_with_vt: ldms=${vt_ldms_enabled}") endif() - target_include_directories(${ARG_TARGET} SYSTEM PUBLIC - ${vt_ldms_includes} - ) - target_link_directories(${ARG_TARGET} PUBLIC ${vt_ldms_libs}) + if(${vt_ldms_includes}) + message(STATUS "Using user provided vt_ldms_includes=${vt_ldms_includes}") + target_include_directories(${ARG_TARGET} SYSTEM PUBLIC + ${vt_ldms_includes} + ) + else() + message(STATUS "vt_ldms_includes CMake variable not set") + endif() + + if(${vt_ldms_libs}) + target_link_directories(${ARG_TARGET} PUBLIC ${vt_ldms_libs}) + message(STATUS "Using user provided vt_ldms_libs=${vt_ldms_libs}") + else() + message(STATUS "vt_ldms_libs CMake variable not set") + endif() + target_link_libraries( - ${ARG_TARGET} PUBLIC ${ARG_BUILD_TYPE} :libldms.so :libldmsd_stream.so - ) + ${ARG_TARGET} PUBLIC ${ARG_BUILD_TYPE} :libldms.so :libldmsd_stream.so + ) endif() if (${ARG_CUSTOM_LINK_ARGS})