Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cmake_minimum_required to 3.23 to match vt #354

Closed
JacobDomagala opened this issue Jun 20, 2024 · 0 comments · Fixed by #355
Closed

Bump cmake_minimum_required to 3.23 to match vt #354

JacobDomagala opened this issue Jun 20, 2024 · 0 comments · Fixed by #355
Assignees
@JacobDomagala

Comments

@JacobDomagala
Copy link
Contributor

TODO:

  • update minimum CMake version to match vt
  • We can then update find_package_local to support <PackageName>_ROOT (we use it for Kokkos and KokkosKernels)
@JacobDomagala JacobDomagala self-assigned this Jun 20, 2024
@JacobDomagala JacobDomagala mentioned this issue Jun 20, 2024
Merged
JacobDomagala added a commit that referenced this issue Jun 23, 2024
@JacobDomagala
#354: Bump minimum CMake version to 3.23 and update find_package_loca…
8310258 
…l to work with packageName_ROOT
JacobDomagala added a commit that referenced this issue Jun 24, 2024
@JacobDomagala
#354: Bump minimum CMake version to 3.23 and update find_package_loca…
44a10b9 
…l to work with packageName_ROOT
@JacobDomagala JacobDomagala linked a pull request Jun 24, 2024 that will close this issue
#354: Bump minimum CMake version to 3.23 and update find_package_local to work with packageName_ROOT #355
Merged
@JacobDomagala JacobDomagala mentioned this issue Jun 24, 2024
Merged
JacobDomagala added a commit that referenced this issue Jun 24, 2024
@JacobDomagala
#354: Update packageName_ROOT variable to hold multiple prefixes
d251958
JacobDomagala added a commit that referenced this issue Jun 24, 2024
@JacobDomagala
#354: Update packageName_ROOT variable to hold multiple prefixes
5816645
JacobDomagala added a commit that referenced this issue Jun 24, 2024
@JacobDomagala
#354: Use 3.23 CMake for all CI pipelines
3815ada
JacobDomagala added a commit that referenced this issue Jun 24, 2024
@JacobDomagala
#354: Fix issue when optional package is being used with packageName_…
1581715 
…ROOT CMake variable
JacobDomagala added a commit that referenced this issue Jun 25, 2024
@JacobDomagala
#354: Remove no longer used variable in find_packge_local
25a453c
@JacobDomagala JacobDomagala mentioned this issue Jun 26, 2024
Closed
JacobDomagala added a commit that referenced this issue Jun 26, 2024
@JacobDomagala
#354: Update the way we point to Kokkos' install directory
61e15e7
JacobDomagala added a commit that referenced this issue Jun 26, 2024
@JacobDomagala
#354: Update the way we point to Kokkos' install directory
bc9a21b
lifflander added a commit that referenced this issue Jul 3, 2024
@lifflander
Merge pull request #355 from DARMA-tasking/354-bump-cmake_minimum_req…
78f27b4 
…uired-to-323-to-match-vt

#354: Bump minimum CMake version to 3.23 and update `find_package_local` to work with `packageName_ROOT`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JacobDomagala