Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent of strategy name in BENCHMARK.md #36

Open
Opdoop opened this issue Dec 16, 2021 · 0 comments
Open

Inconsistent of strategy name in BENCHMARK.md #36

Opdoop opened this issue Dec 16, 2021 · 0 comments

Comments

@Opdoop
Copy link

Opdoop commented Dec 16, 2021

According to HISTORY.md, BertSamplingStrategy has been renamed to ASRSStrategy, but it remain BertSamplingStrategy in BENCHMARK.md. Thus update of BENCHMARK.md is needed.

By the way, I think descriptions in Advanced Usage examples could improve. The current description is too short, and there are some inaccurate parameter usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Opdoop