Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words in song titles getting split in two lines #34

Open
El-Tahur opened this issue Sep 19, 2024 · 2 comments
Open

Words in song titles getting split in two lines #34

El-Tahur opened this issue Sep 19, 2024 · 2 comments
Labels
bug Something isn't working future update May be fixed or added in a future update rockbox issue This issue is a problem with Rockbox, not adwaitapod.

Comments

@El-Tahur
Copy link

El-Tahur commented Sep 19, 2024

Device: iPod 6.5th gen
Rockbox Version: Daily build 20240919
Adwaitapod Theme: adwaitapod dark simplified
Downloaded From: Rockbox Theme site
Description:
I don't know if this is a bug or an intended feature, in some songs the name of the song is split in two lines instead of showing the whole name in one line while scrolling, both album and artist display their names correctly.
The main problem is that the split does not take in consideration spaces so it cuts words in half most of the time.
Maybe the solution is to keep the text in just one line for every song.

@El-Tahur El-Tahur added the bug Something isn't working label Sep 19, 2024
@D0-0K
Copy link
Owner

D0-0K commented Sep 21, 2024

Hi there, thanks for reporting this!

So the split line song title code comes pretty much piece for piece from Themify 1, it's a very static solution that display a set amount of characters from the song title over 2 lines if the song title isn't too long. I've been majorly limited by Rockbox when it came to making it smarter, ideally I would like to have a function that searches for spaces in the song title and adapt the split to avoid breaking words however until recently I had no way to check for blank spaces.
I have been working on a potential solution for this in Themify 2, exploiting some rather buggy/edge case behaviour in how Rockbox compares numbers and characters. It's rather theoretical still, though I have managed to confirm that it's possible to target spaces with this method.

To cut a long story short, next version I hope to have this fixed but I have no idea when that will be.

@D0-0K D0-0K added rockbox issue This issue is a problem with Rockbox, not adwaitapod. future update May be fixed or added in a future update labels Sep 21, 2024
@El-Tahur
Copy link
Author

It's good to hear that you are still improving this awesome theme, I'll be looking forward for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working future update May be fixed or added in a future update rockbox issue This issue is a problem with Rockbox, not adwaitapod.
Projects
None yet
Development

No branches or pull requests

2 participants