Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null exception on GetHashCode when adding a null string-based unit into a HashSet or as a key of a Dictionary. #58

Open
vitaliano-fortis opened this issue Oct 25, 2024 · 0 comments
Open

Null exception on GetHashCode when adding a null string-based unit into a HashSet or as a key of a Dictionary. #58

vitaliano-fortis opened this issue Oct 25, 2024 · 0 comments

Comments

@vitaliano-fortis
Copy link

It seems a null check is needed here:

UnitGenerator/src/UnitGenerator/SourceGenerator.cs

Line 476 in ad84e76

return value.GetHashCode();

I suggest using something like: return value?.GetHashCode() ?? 0;.

Thank you for the great work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vitaliano-fortis