Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items with internal blood tanks do weird NBT things, which breaks auto-crafting. #1089

Open
Artikae opened this issue Jan 21, 2025 · 3 comments

Comments

@Artikae
Copy link

Artikae commented Jan 21, 2025

Issue type:

  • 🐛 Bug

Short description:

Items which contain an internal blood tank, like "Rejuvenated Flesh" or "Mace of Destruction", don't receive the NBT data for that tank until a player interacts with them in some way. The problem is that, if you craft one of these items using Integrated Dynamics Auto-crafting, the crafting bill will never complete, because the item is missing its NBT data.

This also causes similar issues for AE2.

Steps to reproduce the problem:

  1. Set up an Integrated Dynamics Auto-Crafting system with a recipe for Rejuvenated Flesh and the appropriate materials. (Important: If you add the recipe using JEI, the bug won't happen. you need to enter it manually.)
  2. Ask it to craft one.
  3. Use a Crafting Job Terminal to observe that the bill is still pending. It will only complete when you open the chest that contains the finished product.

Expected behaviour:

The items would have the same NBT regardless of whether a player has looked at them at any point.


Versions:

  • This mod: 1.2.50
  • Minecraft: 1.20.1
  • Mod loader version: Forge 47.3.0

Also used:

  • CommonCapabilites: 2.9.4
  • Cyclops Core: 1.19.6
  • Integrated Dynamics: 1.25.0
  • Integrated Crafting: 1.1.9
  • Integrated Terminals: 1.6.4
  • Integrated Tunnels: 1.8.33

Log file:

n/a

@rubensworks
Copy link
Member

Thanks for reporting!

@Jack-McKalling
Copy link
Contributor

I'm assuming you mean Cyclops Core 1.19.5, as .6 doesn't exist yet.
What's your correct Integrated Dynamics version? Version 1.1.9 is for ICrafting.

@Artikae
Copy link
Author

Artikae commented Jan 22, 2025

Sorry, Integrated Dynamics is version 1.25.0.
Cyclops Core is this version: https://modrinth.com/mod/cyclops-core/version/1.20.1-1.19.6

Modrinth
Download Cyclops Core 1.20.1-1.19.6 on Modrinth. Supports 1.20.1 Forge. Published on Dec 13, 2024. 2319 downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

No branches or pull requests

3 participants