Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for patcher preset names in set presets #183

Open
x37v opened this issue Dec 9, 2024 · 1 comment
Open

add support for patcher preset names in set presets #183

x37v opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@x37v
Copy link
Contributor

x37v commented Dec 9, 2024

in the latest develop branch of the runner, there are 2 configuration entries we need to support in the web ui:

{
  "FULL_PATH": "/rnbo/config/set_preset_default_patcher_named",
  "TYPE": "F",
  "VALUE": null,
  "ACCESS": 3,
  "CLIPMODE": "none",
  "DESCRIPTION": "Default set presets store latest preset loaded in instance instead of all of its parameter values"
}

and

{
  "FULL_PATH": "/rnbo/inst/0/config/set_preset_patcher_named",
  "TYPE": "F",
  "VALUE": null,
  "ACCESS": 3,
  "CLIPMODE": "none",
  "DESCRIPTION": "Should set presets saved simply store the name of the last patcher instance preset loaded/saved"
}

re #178

@x37v x37v added the enhancement New feature or request label Dec 9, 2024
@x37v x37v added this to the 1.4.0 milestone Dec 9, 2024
@fde31
Copy link
Member

fde31 commented Jan 3, 2025

OK I've added support for the former on fde/set_preset_scope_setting. However, I think the description could use some tweaks to make it easier to understand what this actually does. Considering it's a boolean toggle in the UI

Default set presets store latest preset loaded in instance instead of all of its parameter values

seems a bit abstract on first glance. Should it be saying something about "snapshots" vs "presets" or the like?

For the second I am slightly unsure how to deal with it at this point and if it's necessary to address #178. Does this allow to control the same as set_preset_default_patcher_named but on an instance level or what does it add? Reading through #178 and checking the behavior I assume you have already changed the way [/rnbo/inst/<id>/presets/initial works as in being instance, not patcher scoped at this point which I guess gets us there or am I missing something?

Also when visting /rnbo/inst/0/presets/initial it says

"DESCRIPTION": "Indicate a preset, by name, that should be loaded every time this patch is reloaded. Set to an empty string to load the last loaded preset instead"

would it be correct to change this to say "instance" instead of "patch"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants