Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First play of a patch plays some of the parameters with their RNBO default values insteas of the set value in metasound #56

Open
Tomavatars opened this issue Nov 22, 2024 · 4 comments
Assignees

Comments

@Tomavatars
Copy link

I was suspecting some problems about parameters the first time an RNBO patch is played.
Some parameters (and I don't know why only some parameters) are not updated when a patch is triggered once, only after the patch has been playing a first time.

I don't know why certain parameters are well played when you change their values and not other.
Here is a video showing that when you play a patch the first time, the pitch enveloppe decay is not playing the right value, but then on the second trigger, it plays well.

Here's also my Max/RNBO patch

SYN_Drum_DaKick.maxpat.zip

CleanShot.2024-11-22.at.16.31.45.mp4
@jinpavg
Copy link
Contributor

jinpavg commented Nov 22, 2024

Hi @Tomavatars, this seems related to #19 , where we needed to adjust execution order so that triggers were evaluated before float params, but in this case, it is not triggers but MIDI notes.

However... I'm unable to reproduce the issue using the Feedback Synth patch from the RNBO Intro patch (see the Extras menu in Max), Unreal 5.4, and the current version of this repo on main.

image

I tried to open your SYN_Drum_DaKick patch, but I am missing some files including the abstractions AV.Env.ADSR and TAV_MC Gate.

I'm happy to try again with your patch, but can you send it along with all its dependencies.

Can you also share --

  1. Your RNBO version
  2. Your Max version
  3. Your Unreal version
  4. What branch of this repo are you using, are you up to date?

@Tomavatars
Copy link
Author

Here you are.
RNBO version: 1.3.2 (1.3.3 is crashing the integration - made an issue #54 )
Max version: 8.6.5
Unreal version 5.4.4
Latest branch I believe (Main ?)

Abstractions.zip

@jinpavg
Copy link
Contributor

jinpavg commented Nov 22, 2024

okay @x37v, I've boiled down a simpler repro here -- in the attached zip, open SYN_Drum_DaKick-simpler.maxpat

in Unreal Engine, set the FCutoff to something small like 0.0 and the FDecay to 1.0, then set up the graph like the below:

image

With those values set on the node, you can hear that the first sound, triggered by "OnPlay," has an open filter, and the correctly closed filter does not apply until you send another trigger later.

Abstractions-edit.zip

@jinpavg
Copy link
Contributor

jinpavg commented Nov 22, 2024

@Tomavatars thank you for the clear info, I was able to repro thanks to your reply -- I left some notes for you over on ticket #54, because I can use 1.3.3 without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants