Write more specs

Author: Christian Blank

spec/Type/AnyTypeSpec.php

@@ -12,4 +12,28 @@ function it_is_initializable()
     {
         $this->shouldHaveType(AnyType::class);
     }
+
+    function it_should_return_valid_for_null()
+    {
+        $this->check(null)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_empty_errors_for_null()
+    {
+        $this->check(null)->getErrors()->shouldHaveCount(0);
+    }
+
+    function it_should_return_valid_for_all_values()
+    {
+        $this->check(true)->isValid()->shouldBe(true);
+        $this->check("foo")->isValid()->shouldBe(true);
+        $this->check(13)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_empty_errors_for_all_values()
+    {
+        $this->check(true)->getErrors()->shouldHaveCount(0);
+        $this->check("foo")->getErrors()->shouldHaveCount(0);
+        $this->check(13)->getErrors()->shouldHaveCount(0);
+    }
 }

spec/Type/BoolTypeSpec.php

@@ -2,14 +2,29 @@
 
 namespace spec\StructureCheck\Type;
 
-use StructureCheck\Type\BoolType;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
+use StructureCheck\Type\BoolType;
 
 class BoolTypeSpec extends ObjectBehavior
 {
+
     function it_is_initializable()
     {
         $this->shouldHaveType(BoolType::class);
     }
+
+    function it_should_return_valid_for_bool()
+    {
+        $this->check(true)->isValid()->shouldBe(true);
+        $this->check(false)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_invalid_for_others()
+    {
+        $this->check(null)->isValid()->shouldBe(false);
+        $this->check("foo")->isValid()->shouldBe(false);
+        $this->check([])->isValid()->shouldBe(false);
+        $this->check(1)->isValid()->shouldBe(false);
+        $this->check(1.0)->isValid()->shouldBe(false);
+    }
 }

spec/Type/FloatTypeSpec.php

@@ -4,12 +4,29 @@
 
 use StructureCheck\Type\FloatType;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 
 class FloatTypeSpec extends ObjectBehavior
 {
     function it_is_initializable()
     {
         $this->shouldHaveType(FloatType::class);
     }
+
+    function it_should_return_valid_for_floats()
+    {
+        $this->check(0.0)->isValid()->shouldBe(true);
+        $this->check(1.1)->isValid()->shouldBe(true);
+        $this->check(2.0)->isValid()->shouldBe(true);
+        $this->check(-144.2)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_invalid_for_others()
+    {
+        $this->check(null)->isValid()->shouldBe(false);
+        $this->check("foo")->isValid()->shouldBe(false);
+        $this->check([])->isValid()->shouldBe(false);
+        $this->check(1)->isValid()->shouldBe(false);
+        $this->check(true)->isValid()->shouldBe(false);
+        $this->check(false)->isValid()->shouldBe(false);
+    }
 }

spec/Type/IntTypeSpec.php

@@ -12,4 +12,22 @@ function it_is_initializable()
     {
         $this->shouldHaveType(IntType::class);
     }
+
+    function it_should_return_valid_for_integers()
+    {
+        $this->check(0)->isValid()->shouldBe(true);
+        $this->check(1)->isValid()->shouldBe(true);
+        $this->check(20)->isValid()->shouldBe(true);
+        $this->check(-144)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_invalid_for_others()
+    {
+        $this->check(null)->isValid()->shouldBe(false);
+        $this->check("foo")->isValid()->shouldBe(false);
+        $this->check([])->isValid()->shouldBe(false);
+        $this->check(1.234)->isValid()->shouldBe(false);
+        $this->check(true)->isValid()->shouldBe(false);
+        $this->check(false)->isValid()->shouldBe(false);
+    }
 }

spec/Type/NullableTypeSpec.php

@@ -2,9 +2,9 @@
 
 namespace spec\StructureCheck\Type;
 
+use StructureCheck\Result;
 use StructureCheck\Type\NullableType;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use StructureCheck\Type\TypeInterface;
 
 class NullableTypeSpec extends ObjectBehavior
@@ -14,4 +14,15 @@ function it_is_initializable(TypeInterface $childType)
         $this->beConstructedWith($childType);
         $this->shouldHaveType(NullableType::class);
     }
+
+    function it_should_return_valid_for_null(TypeInterface $childType) {
+        $this->beConstructedWith($childType);
+        $this->check(null)->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_the_value_from_the_child(TypeInterface $childType) {
+        $this->beConstructedWith($childType);
+        $childType->check(false)->willReturn(new Result(false, []));
+        $this->check(false)->isValid()->shouldBe(false);
+    }
 }

spec/Type/StringTypeSpec.php

@@ -12,4 +12,20 @@ function it_is_initializable()
     {
         $this->shouldHaveType(StringType::class);
     }
+
+    function it_should_return_valid_for_strings()
+    {
+        $this->check("")->isValid()->shouldBe(true);
+        $this->check("fooo")->isValid()->shouldBe(true);
+        $this->check('adadsad asd a')->isValid()->shouldBe(true);
+    }
+
+    function it_should_return_invalid_for_others()
+    {
+        $this->check(null)->isValid()->shouldBe(false);
+        $this->check(12.3)->isValid()->shouldBe(false);
+        $this->check([])->isValid()->shouldBe(false);
+        $this->check(-1)->isValid()->shouldBe(false);
+        $this->check(true)->isValid()->shouldBe(false);
+    }
 }

src/Result.php

@@ -36,14 +36,14 @@ public function __construct($valid, array $errors)
      */
     public function isValid()
     {
-        return true;
+        return $this->valid;
     }
 
     /**
      * @inheritdoc
      */
     public function getErrors()
     {
-        return [];
+        return $this->errors;
     }
 }

src/Type/AnyType.php

@@ -2,6 +2,19 @@
 
 namespace StructureCheck\Type;
 
-class AnyType
+use StructureCheck\Result;
+
+/**
+ * Class AnyType
+ * @package StructureCheck\Type
+ */
+class AnyType implements TypeInterface
 {
-}
+    /**
+     * @inheritdoc
+     */
+    public function check($value)
+    {
+        return new Result(true, []);
+    }
+}

src/Type/BoolType.php

@@ -20,7 +20,7 @@ class BoolType implements TypeInterface
      */
     public function check($value)
     {
-        $checkResult = is_string($value);
+        $checkResult = is_bool($value);
 
         return new Result(
             $checkResult,

src/Type/FloatType.php

@@ -2,14 +2,14 @@
 
 namespace StructureCheck\Type;
 
+use StructureCheck\Result;
+
 class FloatType implements TypeInterface
 {
     private static $errorMessage = 'The value %s is not a float.';
 
     /**
-     * @param mixed $value
-     *
-     * @return ResultInterface
+     * @inheritdoc
      */
     public function check($value)
     {