Change constructor of result object

* Update informations
* Make errors parameter in result constructor optional

Author: Christian Blank

.scrutinizer.yml

@@ -6,6 +6,11 @@ tools:
     config:
       standard: PSR2
 
+checks:
+    php:
+        code_rating: true
+        duplication: true
+
 filter:
   excluded_paths:
     - docs/*

README.md

@@ -2,6 +2,9 @@ PHP Structure Check
 ===================
 
 [![Build Status](https://travis-ci.org/1blankz7/php-structure-check.svg?branch=master)](https://travis-ci.org/1blankz7/php-structure-check)
+[![Latest Stable Version](https://poser.pugx.org/1blankz7/php-structure-check/v/stable)](https://packagist.org/packages/1blankz7/php-structure-check)
+[![Total Downloads](https://poser.pugx.org/1blankz7/php-structure-check/downloads)](https://packagist.org/packages/1blankz7/php-structure-check)
+[![License](https://poser.pugx.org/1blankz7/php-structure-check/license)](https://packagist.org/packages/1blankz7/php-structure-check)
 
 This library can check a complex array structure against a given requirement.
 The purpose of this library is to create a better experience when testing a result set from an api or something similar.

composer.json

@@ -2,7 +2,7 @@
     "name":         "1blankz7/php-structure-check",
     "description":  "Structural check of arrays for PHP 5.6+",
     "keywords":     ["array", "structure", "types"],
-    "homepage":     "http://phpspec.net/",
+    "homepage":     "https://github.com/1blankz7/php-structure-check",
     "type":         "library",
     "license":      "MIT",
     "authors":      [
@@ -12,8 +12,6 @@
             "homepage":  "http://cblank.de"
         }
     ],
-    "require": {
-    },
     "require-dev": {
         "phpspec/phpspec": "^3.2"
     },

spec/CheckerSpec.php

@@ -22,6 +22,6 @@ function it_accepts_a_type_and_an_array_as_parameter_for_fulfills(TypeInterface
     function it_returns_the_result_of_the_type_in_fulfills(TypeInterface $type, ResultInterface $result)
     {
         $type->check([])->willReturn($result);
-        $this->fulfills([], $type)->shouldBeAnInstanceOf(ResultInterface::class);
+        $this->fulfills([], $type)->shouldBe($result);
     }
 }

spec/ResultSpec.php

@@ -2,17 +2,33 @@
 
 namespace spec\StructureCheck;
 
-use StructureCheck\Result;
 use PhpSpec\ObjectBehavior;
+use StructureCheck\Result;
 
 class ResultSpec extends ObjectBehavior
 {
-    function let() {
-        $this->beConstructedWith(true, []);
-    }
 
     function it_is_initializable()
     {
+        $this->beConstructedWith(true, []);
         $this->shouldHaveType(Result::class);
     }
+
+    function it_will_return_is_valid_if_it_was_set_in_constructor()
+    {
+        $this->beConstructedWith(true, []);
+        $this->isValid()->shouldBe(true);
+    }
+
+    function it_will_return_is_invalid_if_it_was_set_in_constructor()
+    {
+        $this->beConstructedWith(false, []);
+        $this->isValid()->shouldBe(false);
+    }
+
+    function it_will_return_an_empty_array_if_no_error_list_is_given()
+    {
+        $this->beConstructedWith(true);
+        $this->getErrors()->shouldHaveCount(0);
+    }
 }

src/Result.php

@@ -25,7 +25,7 @@ class Result implements ResultInterface
      * @param bool $valid
      * @param array $errors
      */
-    public function __construct($valid, array $errors)
+    public function __construct($valid, array $errors = [])
     {
         $this->valid = $valid;
         $this->errors = $errors;

src/Type/AnyType.php

@@ -15,6 +15,6 @@ class AnyType implements TypeInterface
      */
     public function check($value)
     {
-        return new Result(true, []);
+        return new Result(true);
     }
 }

src/Type/NullableType.php

@@ -32,7 +32,7 @@ public function __construct(TypeInterface $child)
     public function check($value)
     {
         if(is_null($value)) {
-            return new Result(true, []);
+            return new Result(true);
         }
 
         return $this->child->check($value);