Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPROVIDER_EXCEL requires initialize_excel in all classes #6

Open
tingeman opened this issue Dec 9, 2020 · 0 comments
Open

PPROVIDER_EXCEL requires initialize_excel in all classes #6

tingeman opened this issue Dec 9, 2020 · 0 comments

Comments

@tingeman
Copy link
Collaborator

tingeman commented Dec 9, 2020

The new PPROVIDER_EXCEL requires an initialize_excel method to be present in all classes in order to be compatible.

What is the intention behind requiring this dependency?

It breaks the design philosophy that the core model classes should be unaware how parameters are obtained.
When a new PROVIDER class is implemented, all other classes in the model will have to be modified with a new initialize_newprovider method, if we are to follow the PPROVIDER_EXCEL implementation.

What is the use case scenario, where a particular class needs to know if the data came from an Excel or a Yaml file or something else?

Could we change it to just a generic initialize method, without loss of functionality, and thus avoid touching all classes when a new provider class is implemented?

tingeman added a commit that referenced this issue Dec 13, 2021
Pull CryoGrid/CryoGrid changes into tingeman/CryoGrid before push of changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant