Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update mysql connector #165

Open
maggi373 opened this issue Oct 9, 2024 · 4 comments
Open

[FEATURE] Update mysql connector #165

maggi373 opened this issue Oct 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@maggi373
Copy link

maggi373 commented Oct 9, 2024

We use advanced ban to sync our bans between our modded servers and modern vanilla, however we use mysql 8 as our database as luckyperms and alike also support that version. is it possible to update crucible's db connector.

i've been running my own fork of thermos for two years or so with version mysql:mysql-connector-java:8.0.28 and its stable. there is probably newer versions but i havent looked into those, i think there was something noteworthy after 29 ?

The fork is now archived as i there was just to much issues with the build process and the discovery of crucible.
https://github.com/Thorfusion/Thermos

i can make pr if wanted/needed

@maggi373 maggi373 added the enhancement New feature or request label Oct 9, 2024
@EverNife
Copy link
Member

Is not a common practice for plugins to embed their libs in their jars with a relocated path?
Would that not suit your need in this specific case?

Even though, if there is no break this might be possible just like we updated fast utils.
But different from fastutils, mysql might be used by many plugins.

The upgrade if from mysql-connector 5.1.14 to 8.0.28
We should be aware of the breaking changes between these two versions, where there a lot?
I asked chat GPT here for a summary, it seems a lot '-'

@maggi373
Copy link
Author

mysql 5 is depricated and insecure so i highly doubt anyone is running it anymore.

yes most plugins has their own libs, like luckperms. but advanced ban does not.
most plugins i googled had updated versions for mysql 8, like mysql for essentials extension

@maggi373
Copy link
Author

i can always compile crucible with mysql 8, just that the other servers running my fork of thermos also uses the mysql feature and probably others also want it

@juanmuscaria
Copy link
Member

Updating that library seems fine, anything using the connector internal classes internally would be to blame if it breaks. Feel free to make a PR as I don't see any issue updating that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants