Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a native looking theme again #138

Open
Croydon opened this issue Nov 11, 2017 · 3 comments
Open

Implement a native looking theme again #138

Croydon opened this issue Nov 11, 2017 · 3 comments

Comments

@Croydon
Copy link
Owner

Croydon commented Nov 11, 2017

The former "none" theme, which used Firefox's UI CSS got removed, since this wasn't possible anymore with a WebExtension due to sandboxing.

Starting with Firefox 58 it will be possible again.

https://bugzilla.mozilla.org/show_bug.cgi?id=1349944
https://bugzilla.mozilla.org/show_bug.cgi?id=1415872
https://bugzilla.mozilla.org/show_bug.cgi?id=1347188

I plan to reimplement it at some point. It might be necessary to wait a bit longer even after the release of Firefox 58 till the point, when Firefox themes are supporting more attributes again.

@nt1m
Copy link

nt1m commented Nov 14, 2017

browser.theme.getCurrent() only works with webextension themes (like VivaldiFox or Container theme). For the default theme, it will just return {}.

@ntninja
Copy link

ntninja commented Nov 15, 2017

@nt1m: But you should be able to use the legacy system colors (contain values from the current system's theme), when no overrides by the browser theme are set.

@Croydon
Copy link
Owner Author

Croydon commented Apr 6, 2018

I'm likely going to postpone this till the current very active work on themes is finished. Many new theme attributes are getting added and the default themes are getting refactored, both progresses may be of good use.

@Croydon Croydon added this to the 0.14.0 milestone Apr 28, 2018
@Croydon Croydon pinned this issue Feb 24, 2019
@Croydon Croydon modified the milestones: 0.14.0, 0.15.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants