Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encodings used. #8

Open
pushfoo opened this issue May 9, 2020 · 4 comments
Open

Fix encodings used. #8

pushfoo opened this issue May 9, 2020 · 4 comments

Comments

@pushfoo
Copy link
Member

pushfoo commented May 9, 2020

Encoding should be Windows-1252/CP-1252, not latin-1 according to themaltster.

@KeyboardInterrupt
Copy link
Member

Good to know, I will look into this!
I never encountered any issues with latin-1 though, do you have a Source for this?

@KeyboardInterrupt
Copy link
Member

@pushfoo
Copy link
Member Author

pushfoo commented May 17, 2020

During work on #7 , @ligfx brought up the following question about python & encodings when I asked about edge cases for PRAY block names:

Can python do best fit mappings?

I'm leaving a note here because it appears to be out of scope for #7 and I don't understand ligatures or their encodings well enough at the moment to make sense of it.

@pushfoo
Copy link
Member Author

pushfoo commented May 26, 2020

Assuming we treat ligatures and other characters as something that should raise an exception, this should be easy. It can build off of work already present in the branch for #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants