Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit approving translations yourself in Crowdin #126

Open
Andrulko opened this issue Apr 7, 2023 · 9 comments
Open

Omit approving translations yourself in Crowdin #126

Andrulko opened this issue Apr 7, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@Andrulko
Copy link
Contributor

Andrulko commented Apr 7, 2023

Hey,

I was very happy to see you have so high translations approval progress in the project:
https://crowdin.com/project/pimple-popper

When I checked the details, I was not that happy 🥹

For example, Ukrainian is 100% translated and approved:
https://crowdin.com/project/pimple-popper/uk

The approved translation is protected, even if the community will submit another, better translation it would be simply ignored because there is already an approved one. For example, here is a partially translated string that's approved by the owner:
https://crowdin.com/translate/pimple-popper/48/en-uk#716

Please omit approving translations from the owner's name when translations are uploaded, it may be counter-productive. Your translators can always vote for the best translations + you can have a real proofreader in every language at later stages. Only perfect translations deserve to be approved 😉

I'd recommend canceling all approvals made by CrazyMarvin. It would be quite fast to do via multilingual view (select all strings -> remove approvals):
https://crowdin.com/multilingual/pimple-popper/48?languages=fr,af,ar,ca,cs,da,fi,nl,zhcn,zhtw&filter=basic&value=3

I can help on my side but need some approval from @CrazyMarvin first

@CrazyMarvin
Copy link
Contributor

That's a very good note. I just dis-approved the translations of the translation.csv file.

Do you know why this warning appears on Crowdin?
crowdin

@Andrulko
Copy link
Contributor Author

Andrulko commented Apr 7, 2023

Great, thanks!

@CrazyMarvin It seems your scheme is incorrect, I noticed some inconsistencies and created a PR:
#132

Let's start from here, please merge it and let's see how the file will be updated. I hope columns order in CSV didn't change?

@CrazyMarvin
Copy link
Contributor

Thank you very much.
The order did not change but I noticed some inconsistencies. Let's see. 😅

@Andrulko
Copy link
Contributor Author

Andrulko commented Apr 7, 2023

Not red anymore 🎉

@Andrulko
Copy link
Contributor Author

Andrulko commented Apr 7, 2023

Oops, I did it again!
#134

Apologies, I just realized you have an extra en defined in your scheme that should be removed to prevent translations export issue

@Andrulko
Copy link
Contributor Author

Andrulko commented Apr 7, 2023

Thanks for merging, the scheme is fully valid now and translations should be delivered to the proper columns

@CrazyMarvin
Copy link
Contributor

Thank you very much, @Andrulko. 😘
Let's have an eye on the next PRs from Crowdin. 👀
I have a good feeling though. 😊

@CrazyMarvin CrazyMarvin added the enhancement New feature or request label Apr 8, 2023
@Andrulko
Copy link
Contributor Author

@CrazyMarvin Just noticed today that because of invalid scheme that was defined before, invalid translations were uploaded to the project. I canceled recent uploads already, so now every language looks good.

Please merge the latest PR as soon as possible
#144

@CrazyMarvin
Copy link
Contributor

Thanks for checking. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants