Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading with librarian villager accepts crazyenchantment book as if it were a vanilla book #869

Open
2 of 3 tasks
TristinCodingham opened this issue Jan 7, 2025 · 0 comments
Assignees

Comments

@TristinCodingham
Copy link

Spark link

No response

Plugin Version

2.5.1

Server Version

1.21.1

Server Platform

Purpur

Describe the bug

When trading with a librarian villager, clicking on the trade in the GUI to automatically insert required items for that trade, can put a crazyenchantment book as if it were a vanilla book. Trading then consumes the CE book. Players are susceptible to losing their CE books if not vigilant enough

Steps to reproduce

What you will need:

  • A librarian villager (any level)
  • Enough emeralds to trade with whatever trade they have
  • A crazyenchantment book (no vanilla book)

Steps to reproduce:

  1. Right click villager to trade
  2. Click on the trade in the left side GUI panel:
    2025-01-07_10 50 50
  3. Notice on the right side GUI panel that it has placed the CE book
    2025-01-07_10 55 18
  4. Complete the trade and notice it has consumed the CE book, losing the book and it's enchantment

Additional context

Perhaps there is an event that runs when a villager is traded with, if so, listen to that event and check if the book being traded in is a CE book, if so, cancel the event and send the player a message stating that they cannot trade CE books.

This is more a quality of life update if it were to be implemented.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I ticked all the boxes without actually reading them
  • My version of Minecraft is supported by CrazyCrew.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants