Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL-2458 #597

Merged
merged 1 commit into from
Sep 3, 2024
Merged

MTL-2458 #597

merged 1 commit into from
Sep 3, 2024

Conversation

jpdavis-prof
Copy link
Contributor

@jpdavis-prof jpdavis-prof commented Aug 30, 2024

Summary and Scope

node-role.kubernetes.io/master is deprecated in k8s 1.24
replaced with node-role.kubernetes.io/control-plane

Issues and Related PRs

https://jira-pro.it.hpe.com:8443/browse/MTL-2458

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jpdavis-prof jpdavis-prof requested a review from a team as a code owner August 30, 2024 21:43
@leliasen-hpe
Copy link
Contributor

In K8s 1.24, master nodes have two taints. They have "node-role.kubernetes.io/master" and "node-role.kubernetes.io/control-plane". Should we check for both taints here?
@dborman-hpe Do you have an opinion?

@dborman-hpe
Copy link

In K8s 1.24, master nodes have two taints. They have "node-role.kubernetes.io/master" and "node-role.kubernetes.io/control-plane". Should we check for both taints here? @dborman-hpe Do you have an opinion?

In K8s 1.24 the taint on the master nodes is only the new node-role.kubernetes.io/control-plane taint (but they have labels for both). So for checking taints it should just be switched to the new taint.

Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdavis-prof jpdavis-prof merged commit e86a488 into release/1.6 Sep 3, 2024
3 checks passed
@jpdavis-prof jpdavis-prof deleted the MTL-2458 branch September 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants