Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASMTRIAGE-6991 goss-servers.service systemd-preset #585

Merged
merged 3 commits into from
May 21, 2024
Merged

CASMTRIAGE-6991 goss-servers.service systemd-preset #585

merged 3 commits into from
May 21, 2024

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented May 17, 2024

Fixes CASMTRIAGE-6991.

Prevents disabling goss-servers.service when upgrading the goss-servers RPM package by installing a systemd-presets file. This new systemd-presets file (/usr/lib/systemd/system-preset/90-goss-servers.preset) will prevent the removal of the systemd symlink for goss-servers.service.

Note below that the service remained enabled following the package update, and that vendor preset: enabled is shown.

ncn-w001:~ # rpm -Uvh rusty/goss-servers-1.17.26~3~geb15ca3-1.noarch.rpm
Preparing...                          ################################# [100%]
Updating / installing...
   1:goss-servers-1.17.26~3~geb15ca3-1################################# [ 50%]
Cleaning up / removing...
   2:goss-servers-1.16.71-1           ################################# [100%]
ncn-w001:~ # systemctl status goss-servers | grep vendor
     Loaded: loaded (/usr/lib/systemd/system/goss-servers.service; enabled; vendor preset: enabled)

rustydb added 2 commits May 17, 2024 11:43
@rustydb
Explicitly callout systemd-rpm-macros
896ce6d 
While this is implicitly required since SLES 12, I want to explicitly require it incase `rpm-build` changes.
Ref: https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#RPM_macros
@rustydb
systemd file rework
692a23f 
Move the systemd files into their own directory.
Replace the `mkdir` and `install` commands in the RPM spec; use RPM macros for their destinations, and make the directory and install the file at the same time.
@rustydb rustydb requested a review from a team as a code owner May 17, 2024 17:30
@rustydb rustydb changed the title CASMTRIAGE-6991 CASMTRIAGE-6991 goss-servers.service systemd-preset May 17, 2024
@rustydb
Copy link
Contributor Author

rustydb commented May 17, 2024

/backport release/1.5

@github-actions GitHub Actions
Copy link
Contributor

Backporting into branch release/1.5 was successful. New PR: #586

@github-actions github-actions bot mentioned this pull request May 17, 2024
Closed
@rustydb
CASMTRIAGE-6991 enable goss-servers by default
e423daa 
Install a systemd-preset file for goss-servers. This preset file will enable goss-servers by default.
@rustydb rustydb force-pushed the CASMTRIAGE-6991 branch from 5003172 to e423daa Compare May 17, 2024 18:10
@rustydb
Copy link
Contributor Author

rustydb commented May 17, 2024

/backport release/1.5

@github-actions GitHub Actions
Copy link
Contributor

Backporting into branch release/1.5 was successful. New PR: #587

@github-actions github-actions bot mentioned this pull request May 17, 2024
Merged
@rustydb rustydb requested a review from jnowicki-hpe May 17, 2024 18:12
@rustydb rustydb merged commit 4d8f01b into release/1.6 May 21, 2024
3 checks passed
@rustydb rustydb deleted the CASMTRIAGE-6991 branch May 21, 2024 18:56
@rustydb rustydb mentioned this pull request May 21, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharding-hpe mharding-hpe mharding-hpe approved these changes

@spillerc-hpe spillerc-hpe spillerc-hpe approved these changes

@jnowicki-hpe jnowicki-hpe Awaiting requested review from jnowicki-hpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustydb @mharding-hpe @spillerc-hpe