validate inner period param

ayasayadi1 · ayasayadi1 · commit faf26b4d056d · 2024-05-27T08:56:51.000Z
diff --git a/api/lib/countly.common.js b/api/lib/countly.common.js
@@ -786,7 +786,12 @@ countlyCommon.isValidPeriodParam = function(period) {
     }
 
     if (typeof period === 'object') {
-        return Object.prototype.hasOwnProperty.call(period, 'since') || Object.prototype.hasOwnProperty.call(period, 'period');
+        if (Object.prototype.hasOwnProperty.call(period, 'period')) {
+            return countlyCommon.isValidPeriodParam(period.period);
+        }
+        else {
+            return Object.prototype.hasOwnProperty.call(period, 'since')
+        }
     }
 
     return period === 'month' ||

Original file line number	Diff line number	Diff line change
`@@ -786,7 +786,12 @@ countlyCommon.isValidPeriodParam = function(period) {`
`786`	`786`	`}`
`787`	`787`
`788`	`788`	`if (typeof period === 'object') {`
`789`		`- return Object.prototype.hasOwnProperty.call(period, 'since') \|\| Object.prototype.hasOwnProperty.call(period, 'period');`
	`789`	`+ if (Object.prototype.hasOwnProperty.call(period, 'period')) {`
	`790`	`+ return countlyCommon.isValidPeriodParam(period.period);`
	`791`	`+ }`
	`792`	`+ else {`
	`793`	`+ return Object.prototype.hasOwnProperty.call(period, 'since')`
	`794`	`+ }`
`790`	`795`	`}`
`791`	`796`
`792`	`797`	`return period === 'month' \|\|`