Skip to content

Commit e2fc225

Browse files
committed
feedback logs
1 parent 4b6f288 commit e2fc225

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

Countly.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ CountlyState.eventEmitter = eventEmitter;
2424

2525
Countly.feedback = Feedback;
2626
Countly.feedback.state = CountlyState;
27-
Countly.feedback.instance = Countly;
2827

2928
let _isCrashReportingEnabled = false;
3029

@@ -315,7 +314,7 @@ Countly.registerForNotification = function (theListener) {
315314
Countly.configureIntentRedirectionCheck = function (allowedIntentClassNames = [], allowedIntentPackageNames = [], useAdditionalIntentRedirectionChecks = true) {
316315
if (/ios/.exec(Platform.OS)) {
317316
L.e('configureIntentRedirectionCheck, configureIntentRedirectionCheck is not required for iOS');
318-
317+
319318
return 'configureIntentRedirectionCheck : not required for iOS';
320319
}
321320

@@ -495,7 +494,7 @@ Countly.getCurrentDeviceId = async function () {
495494
return result;
496495
};
497496

498-
/**
497+
/**
499498
* Get currently used device Id type.
500499
* Should be called after Countly init
501500
*

Feedback.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import * as L from './Logger.js';
2+
13
const Feedback = {};
24

35
/**
@@ -8,10 +10,10 @@ const Feedback = {};
810
async function getAvailableFeedbackWidgets(onFinished) {
911
if (!Feedback.state.isInitialized) {
1012
const message = "'init' must be called before 'getAvailableFeedbackWidgets'";
11-
Feedback.instance.logError('getAvailableFeedbackWidgets', message);
13+
L.e(`getAvailableFeedbackWidgets, ${message}`);
1214
return { error: message, data: null };
1315
}
14-
16+
L.d('getAvailableFeedbackWidgets, getAvailableFeedbackWidgets');
1517
let result = null;
1618
let error = null;
1719
try {
@@ -38,30 +40,30 @@ async function getAvailableFeedbackWidgets(onFinished) {
3840
function presentFeedbackWidget(feedbackWidget, closeButtonText, widgetShownCallback, widgetClosedCallback) {
3941
if (!Feedback.state.isInitialized) {
4042
const message = "'init' must be called before 'presentFeedbackWidget'";
41-
Feedback.instance.logError('presentFeedbackWidget', message);
43+
L.e(`presentFeedbackWidget, ${message}`);
4244
return { error: message };
4345
}
4446
let message = null;
4547
if (!feedbackWidget) {
4648
message = 'feedbackWidget should not be null or undefined';
47-
Feedback.instance.logError('presentFeedbackWidget', message);
49+
L.e(`presentFeedbackWidget, ${message}`);
4850
return { error: message };
4951
}
5052
if (!feedbackWidget.id) {
5153
message = 'FeedbackWidget id should not be null or empty';
52-
Feedback.instance.logError('presentFeedbackWidget', message);
54+
L.e(`presentFeedbackWidget, ${message}`);
5355
return { error: message };
5456
}
5557
if (!feedbackWidget.type) {
5658
message = 'FeedbackWidget type should not be null or empty';
57-
Feedback.instance.logError('presentFeedbackWidget', message);
59+
L.e(`presentFeedbackWidget, ${message}`);
5860
return { error: message };
5961
}
6062
if (typeof closeButtonText !== 'string') {
6163
closeButtonText = '';
62-
Feedback.instance.logWarning('presentFeedbackWidget', `unsupported data type of closeButtonText : '${typeof args}'`);
64+
L.w(`presentFeedbackWidget, unsupported data type of closeButtonText : [${typeof args}]`);
6365
}
64-
66+
L.d(`presentFeedbackWidget, presentFeedbackWidget with widget:[${JSON.stringify(feedbackWidget)}]`);
6567
if (widgetShownCallback) {
6668
Feedback.state.widgetShownCallback = Feedback.state.eventEmitter.addListener(Feedback.state.widgetShownCallbackName, () => {
6769
widgetShownCallback();
@@ -90,13 +92,13 @@ function presentFeedbackWidget(feedbackWidget, closeButtonText, widgetShownCallb
9092
async function getFeedbackWidgetData(widgetInfo, onFinished) {
9193
if (!Feedback.state.isInitialized) {
9294
const message = "'initWithConfig' must be called before 'getFeedbackWidgetData'";
93-
Feedback.instance.logError('getFeedbackWidgetData', message);
95+
L.e(`getFeedbackWidgetData, ${message}`);
9496
onFinished(null, message);
9597
return { error: message, data: null };
9698
}
9799
const widgetId = widgetInfo.id;
98100
const widgetType = widgetInfo.type;
99-
Feedback.instance.logInfo('getFeedbackWidgetData', 'Calling "getFeedbackWidgetData" with Type:[' + widgetType + ']');
101+
L.d(`getFeedbackWidgetData, Calling "getFeedbackWidgetData" with Type:[${widgetType}]`);
100102
const args = [];
101103
args.push(widgetId);
102104
args.push(widgetType);
@@ -124,12 +126,12 @@ async function getFeedbackWidgetData(widgetInfo, onFinished) {
124126
async function reportFeedbackWidgetManually(widgetInfo, widgetData, widgetResult) {
125127
if (!Feedback.state.isInitialized) {
126128
const message = "'initWithConfig' must be called before 'reportFeedbackWidgetManually'";
127-
Feedback.instance.logError('reportFeedbackWidgetManually', message);
129+
L.e(`reportFeedbackWidgetManually, ${message}`);
128130
return { error: message };
129131
}
130132
const widgetId = widgetInfo.id;
131133
const widgetType = widgetInfo.type;
132-
Feedback.instance.logInfo('reportFeedbackWidgetManually', 'Calling "reportFeedbackWidgetManually" with Type:[' + widgetType + ']');
134+
L.d(`reportFeedbackWidgetManually, Calling "reportFeedbackWidgetManually" with Type:[${widgetType}]`);
133135
const widgetInfoList = [];
134136
widgetInfoList.push(widgetId);
135137
widgetInfoList.push(widgetType);
@@ -144,7 +146,7 @@ async function reportFeedbackWidgetManually(widgetInfo, widgetData, widgetResult
144146
try {
145147
await Feedback.state.CountlyReactNative.reportFeedbackWidgetManually(args);
146148
} catch (e) {
147-
error = e.message;
149+
error = e.message;
148150
}
149151
return { error: error };
150152
}

0 commit comments

Comments
 (0)