Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third-party JSON dependency included in header #34

Open
Zephilinox opened this issue Jan 25, 2022 · 0 comments
Open

third-party JSON dependency included in header #34

Zephilinox opened this issue Jan 25, 2022 · 0 comments

Comments

@Zephilinox
Copy link

The third party dependency nlohmann/json is included in the header, which means clients of this SDK will also be pulling it in. this can conflict with a different but existing version of that library, and also means if a client is using a different JSON library, it now depends on multiple JSON libs. the path specified for that JSON dependency is also hardcoded

it would be great to move this dependency to the .cpp so clients don't need to worry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant