-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default arguments for xarray_filters.datasets.make_* functions #17
Comments
Other TODOs I need to add:
|
I think letting So, what's left is the harder part:
For |
Working on the dask-glm support. |
Note the |
@gpfreitas This is related to issue #5 and #6 and tries to condense them into a TODO list.
Items to do related to the argument specs of
make_*
functions fromxarray_filters.datasets
:MLDataset
be the default return value rather thanDataset
n_samples
argument in this case:MLDataset(make_blobs(n_samples=2000, shape=(200,10)))
wheren_samples
can be taken fromshape
dask_glm
, e.g. make_classification, we should default to making aMLDataset
as in thexarray_filters.datasets
so far, but usedask_glm
's funcs for adask.array
in eachDataArray
rather thansklearn.datasets
numpy
based approach.use_dask_glm=True
keyword to control whether the functions indask_glm.datasets
are used.astype
to the following (or equivalent way of specifying the data structures below as the output type):( 'pandas.dataframe','dask.array', 'dask.dataframe', 'numpy.ndarray', ,'dataset', 'mldataset')
xnames
should belayers
make_blobs
fromxarray_filters
- I think it needs more of the docs from the transformation part explained, e.g. that it typically outputs N-DDataArray
s in anMLDataset
or any differences betweensklearn
andxarray_filters
liken_samples
versusshape
:Note - where I said
dask_glm
above - also look atdask-ml
The text was updated successfully, but these errors were encountered: