Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add remote IP label to containerssh_ssh_current_connections #284

Open
gaocegege opened this issue Nov 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@gaocegege
Copy link
Contributor

Please describe what you would like to see in ContainerSSH

The remote server IP in ssh-proxy backend may change with the config webhook. We cannot get the current connections for a specific server. Thus I propose to add a new label server-ip to the metric containerssh_ssh_current_connections

Please describe your use case

I will create multiple ssh backends. And use them in ssh-proxy mode. The server IP is updated by the config server webhook. And I wanna know how many connections are alive in the server.

@ghost
Copy link

ghost commented Nov 10, 2022

This may have to be an optionally enabled feature since the cardinality can explode if many different backends are used.

@gaocegege
Copy link
Contributor Author

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants