Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website does not have the correct trademark disclaimer #53

Closed
thisisobate opened this issue Jan 23, 2024 · 4 comments · Fixed by ContainerSSH/ContainerSSH#592
Closed

Comments

@thisisobate
Copy link

thisisobate commented Jan 23, 2024

As part of our ongoing effort to cncf/techdocs#198, we noticed that the website does not pass the trademark criteria on CLOMonitor.

To fix this:
Head to the source code of the website. In the <footer> section, add a disclaimer or link to the Linux foundation trademark disclaimer page:

Disclaimer

<footer>
   <p>The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, 
         please see our <a href="https://www.linuxfoundation.org/legal/trademark-usage">Trademark Usage page</a>.
   </p>
</footer>

Link

 <footer>
      <ul>
          <li><a href="https://www.linuxfoundation.org/legal/trademark-usage">Trademarks</a></li>
      </ul>
 </footer>
@tsipinakis
Copy link
Member

It looks like there is something wrong with the detection script. The disclaimer is there on the website:
image

@thisisobate
Copy link
Author

thisisobate commented Jan 30, 2024

The issue here is that there's a forward slash appended to the url:
https://www.linuxfoundation.org/trademark-usage/.

The correct url should be:
https://www.linuxfoundation.org/trademark-usage

Quick Update: I just confirmed from the maintainers of the clomonitor tool that this behavior is indeed a bug caused by site redirects. Let me explain.

The containerssh.io domain automatically redirects to containerssh.io/v5.0/. Now when the clomonitor tool tries to fetch the HTML document from containerssh.io, it fails to generate the actual content of the site; reason is due to the redirect to containerssh.io/v0.5/.

To fix this, please update the website link in ContainerSSH/ContainerSSH github repo to https://containerssh.io/upcoming/.

Note: setting to containerssh.io/v0.5/ or containerssh.io/v0.6/ will require continuous update every now and then. https://containerssh.io/upcoming/ will always remain stable.

Hope that helps!

@tsipinakis
Copy link
Member

Sorry this one fell through. I'd prefer to keep the url pointing to the latest release rather than the in-dev version if possible. Is it possible to override the site CLOMonitor checks? If not, how about simply adding the disclaimer as well to the redirect page?

@thisisobate
Copy link
Author

You can declare an exemption for CLOMonitor in Artifact Hub for this check.

You can take a look at this file to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants