Fix unit tests

Author: bern4rdelli

gauges/indexes.go

@@ -2,6 +2,7 @@ package gauges
 
 import (
 	"time"
+	"github.com/apex/log"
 
 	"github.com/prometheus/client_golang/prometheus"
 )
@@ -67,7 +68,7 @@ type schemaIndexBlocksRead struct {
 }
 
 // IndexBlocksRead returns the sum of the number of disk blocks read from all public indexes
-func (g *Gauges) IndexBlocksRead() *prometheus.GaugeVec {
+func (g *Gauges) IndexBlocksReadBySchema() *prometheus.GaugeVec {
 	var gauge = prometheus.NewGaugeVec(
 		prometheus.GaugeOpts{
 			Name:        "postgresql_index_blocks_read_sum",
@@ -90,7 +91,9 @@ func (g *Gauges) IndexBlocksRead() *prometheus.GaugeVec {
 		for {
 			var schemas []schemaIndexBlocksRead
 			if err := g.query(schemaIndexBlocksReadQuery, &schemas, emptyParams); err == nil {
+				log.WithField("schemas", schemas).Info("started")
 				for _, schema := range schemas {
+					log.Info("*********************************Achou")
 					gauge.With(prometheus.Labels{
 						"schema": schema.Name,
 					}).Set(schema.IndexBlocksRead)
@@ -110,7 +113,7 @@ type schemaIndexBlocksHit struct {
 }
 
 // IndexBlocksHit returns the sum of the number of buffer hits on all user indexes
-func (g *Gauges) IndexBlocksHit() *prometheus.GaugeVec {
+func (g *Gauges) IndexBlocksHitBySchema() *prometheus.GaugeVec {
 	var gauge = prometheus.NewGaugeVec(
 		prometheus.GaugeOpts{
 			Name:        "postgresql_index_blocks_hit_sum",

gauges/indexes_test.go

@@ -29,26 +29,48 @@ func TestUnusedIndexes(t *testing.T) {
 	assertNoErrs(t, gauges)
 }
 
-func TestIndexBlocksRead(t *testing.T) {
+func TestIndexBlocksReadBySchema(t *testing.T) {
 	var assert = assert.New(t)
-	_, gauges, close := prepare(t)
+	db, gauges, close := prepare(t)
 	defer close()
-	var metrics = evaluate(t, gauges.IndexBlocksRead())
+	dropTestTable := createTestTable(t, db)
+	defer dropTestTable()
+	var metrics = evaluate(t, gauges.IndexBlocksReadBySchema())
 	assert.Len(metrics, 1)
 	assertGreaterThan(t, -1, metrics[0])
 	assertNoErrs(t, gauges)
 }
 
-func TestIndexBlocksHit(t *testing.T) {
+func TestIndexBlocksReadBySchemaWithoutIndexes(t *testing.T) {
 	var assert = assert.New(t)
 	_, gauges, close := prepare(t)
 	defer close()
-	var metrics = evaluate(t, gauges.IndexBlocksHit())
+	var metrics = evaluate(t, gauges.IndexBlocksReadBySchema())
+	assert.Len(metrics, 0)
+	assertNoErrs(t, gauges)
+}
+
+func TestIndexBlocksHitBySchema(t *testing.T) {
+	var assert = assert.New(t)
+	db, gauges, close := prepare(t)
+	defer close()
+	dropTestTable := createTestTable(t, db)
+	defer dropTestTable()
+	var metrics = evaluate(t, gauges.IndexBlocksHitBySchema())
 	assert.Len(metrics, 1)
 	assertGreaterThan(t, -1, metrics[0])
 	assertNoErrs(t, gauges)
 }
 
+func TestIndexBlocksHitBySchemaWithoutIndexes(t *testing.T) {
+	var assert = assert.New(t)
+	_, gauges, close := prepare(t)
+	defer close()
+	var metrics = evaluate(t, gauges.IndexBlocksHitBySchema())
+	assert.Len(metrics, 0)
+	assertNoErrs(t, gauges)
+}
+
 // TODO: somehow create some bloated index to proper test this
 func TestIndexBloat(t *testing.T) {
 	var assert = assert.New(t)