Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append EL/CL information to user-defined graffiti #8074

Closed
StefanBratanov opened this issue Mar 13, 2024 · 1 comment · Fixed by #8107
Closed

Append EL/CL information to user-defined graffiti #8074

StefanBratanov opened this issue Mar 13, 2024 · 1 comment · Fixed by #8107
Assignees

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Mar 13, 2024

In addition to #7930 even if user has specified a graffiti we can attempt to append EL/CL information if the space permits it. This will be opt-in feature defaulted to false e.g. append-client-versions-to-validators-graffiti

Some implementation ideas: ethereum/execution-apis#517 (comment)

Add a graffiti versioning "mode" (single CLI option):
Example:

  • CL + CL_VERSION + EL + EL_VERSION (enabled by default)
  • Only CL + EL
  • Nothing

If not enough space, try other modes (e.g. if adding the version does not fit, add at least CL and EL).

Padding?? (need to adjust spec)

@zilm13
Copy link
Contributor

zilm13 commented Mar 14, 2024

I'm thinking on
--validators-graffitti-client-append-format
AUTO_PADDED (default): no user graffitti - full size (20 chars), user graffitti + space + 4-20 characters of whatever left
AUTO: same without space
NAME_PADDED: space (if user graffitti defined) + 4 chars TKBU, client names dropped if more than 32 chars
NAME: same without space
NONE: doesn't touch
Print info status line at startup which graffitti was compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants