Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all Bitcoin rpc client methods are implemented #22

Open
magg opened this issue Jan 6, 2017 · 4 comments
Open

Not all Bitcoin rpc client methods are implemented #22

magg opened this issue Jan 6, 2017 · 4 comments
Labels
good first issue A good issue for first-time contributors help wanted

Comments

@magg
Copy link

magg commented Jan 6, 2017

many methods are missing, any eta on the implementation?

I was interested in addnode for example

thanks

@msgilligan msgilligan changed the title json rpc client is not fully compliant Not all Bitcoin rpc client methods are implemented Jan 6, 2017
@msgilligan
Copy link
Member

Note that you can call arbitrary RPC methods as follows:

client.send("addnode", "209.90.224.4:8333", "add");
client.send("getaddednodeinfo", true);

If the parameters are types that are already supported and you don't need the result converted to a statically typed POJO, this method works fine.

As this is an open-source, mostly volunteer effort, there is no schedule for adding additional methods, but I'm happy to accept pull requests and will try to add specific methods that are requested by the community.

@msgilligan
Copy link
Member

msgilligan commented Jan 6, 2017

@magg I made a quick commit to master 8967393 (and a second one that fixes an omission in my part 537ebc3)

I didn't add any tests, but I'm pretty sure these methods should work. If you're feeling ambitious check out master and give them a try.

Edit: Note that we'll want to replace com.fasterxml.jackson.databind.JsonNode with a POJO implementation of the getaddednodeinfo JSON response, so any code that uses JsonNode will need to be updated when the POJO is added.

@magg
Copy link
Author

magg commented Jan 11, 2017

@msgilligan thank you I just tested the master branch, it works great

@msgilligan
Copy link
Member

Great. Thanks for testing!

@msgilligan msgilligan added the good first issue A good issue for first-time contributors label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue for first-time contributors help wanted
Projects
None yet
Development

No branches or pull requests

2 participants