Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RimbleUtils - return URL as network name for custom networks #25

Open
MikeLockz opened this issue May 3, 2019 · 0 comments
Open

RimbleUtils - return URL as network name for custom networks #25

MikeLockz opened this issue May 3, 2019 · 0 comments

Comments

@MikeLockz
Copy link

Is your feature request related to a problem? Please describe.
As noted in a comment in PR #20 we should use the URL instead of the word 'custom' for ethereum networks that don't match an ID.

Describe the solution you'd like
When a network ID does not match with mainnet or any testnets, use the current network URL as the network name.

Additional context
This would also help with internationalization as we would not need to translate each network name.

@MikeLockz MikeLockz changed the title RimbleUtils - return URL for custom networks RimbleUtils - return URL as network name for custom networks May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant