Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build after tests in travis to help prevent breaks #62

Open
pgoldrbx opened this issue Feb 26, 2018 · 0 comments
Open

Run build after tests in travis to help prevent breaks #62

pgoldrbx opened this issue Feb 26, 2018 · 0 comments
Assignees
Labels

Comments

@pgoldrbx
Copy link
Contributor

Expected Behavior

Our tests run against src but not our build pipeline, which uses rollup. This leaves uncertainty when we update dependencies in our build chain.

Current Behavior

Travis only runs npm test currently, and tests run against our src (using babel)

Possible Solution

  • Adding the build script to travis would be a bare minimum to ensure that the build doesn't break.
  • Alternatively, we could run (or re-run) tests against the our build target(s). This would be more effort and possibly less friendly for local development.

Context

Maintenance becomes easier if we know dependency updates can be reliably accepted.

Your Environment

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants