Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The node does provide meaningful reject reasons since 4.1 #44

Open
abizjak opened this issue Jul 8, 2022 · 0 comments
Open

The node does provide meaningful reject reasons since 4.1 #44

abizjak opened this issue Jul 8, 2022 · 0 comments
Labels
[Type] Bug Something isn't working

Comments

@abizjak
Copy link
Contributor

abizjak commented Jul 8, 2022

Task description

In the README it states
"submit: Fully implemented. If the node rejects the transaction, an error with no details is returned. The server could test for a few possible reasons (validate signatures, check balance, etc.), but the node itself doesn't provide any explanation for the rejection."

which is no longer correct. Since at least 4.1.1 the node returns a description (as an RPC error) of what went wrong if the transaction is not accepted.

This could be returned to the sender/user of the rosetta API.

@abizjak abizjak added [Type] Task An additional feature or improvement. [Type] Bug Something isn't working and removed [Type] Task An additional feature or improvement. labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant