Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report pending finalization committee parameter updates #1099

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Report pending finalization committee parameter updates #1099

merged 1 commit into from
Nov 29, 2023

Conversation

td202
Copy link
Contributor

@td202 td202 commented Nov 28, 2023

Purpose

Fixes #1098

Changes

  • Include the finalization committee parameters in the pending chain updates reported by GetBlockPendingUpdates.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from MilkywayPirate, abizjak and eb-concordium and removed request for MilkywayPirate November 28, 2023 16:10
@td202 td202 merged commit 0e1b4c7 into main Nov 29, 2023
3 checks passed
@td202 td202 deleted the fix-1098 branch November 29, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb-concordium eb-concordium eb-concordium approved these changes

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

@limemloh limemloh limemloh approved these changes

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetBlockPendingUpdates query does not include finalization committee parameter updates
5 participants
@td202 @abizjak @limemloh @MilkywayPirate @eb-concordium