Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasm-pack when minimum supported rust version is 1.74 or above #380

Open
limemloh opened this issue Aug 7, 2024 · 0 comments
Open

Update wasm-pack when minimum supported rust version is 1.74 or above #380

limemloh opened this issue Aug 7, 2024 · 0 comments
Labels
[Type] Maintenance Cleanup or handling of technical debt.

Comments

@limemloh
Copy link
Collaborator

limemloh commented Aug 7, 2024

Bug Description
Building the rust-bindings using rust version 1.79 (maybe other newer versions as well) and wasm-pack version 0.12.1 is causing runtime error: unreachable.
This seems to be fixed by updating wasm-pack to 0.13.0, but this requires a minimum rust version of 1.74.

I have added a unit test which should catch this, when we update the rust version in the future
@limemloh limemloh added the [Type] Bug Something isn't working label Aug 7, 2024
@limemloh limemloh added the [Type] Maintenance Cleanup or handling of technical debt. label Sep 5, 2024 — with Linear
@limemloh limemloh removed the [Type] Bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Maintenance Cleanup or handling of technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@limemloh