Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No limit on decimals in commission rate input fields #297

Open
jens-concordium opened this issue May 6, 2022 · 1 comment
Open

No limit on decimals in commission rate input fields #297

jens-concordium opened this issue May 6, 2022 · 1 comment
Labels
[Prio] Low Should be fixed if time permits but can be postponed. [Type] Bug Something isn't working

Comments

@jens-concordium
Copy link
Contributor

Bug Description

The input fields used to set commission rates dont have a limit on how many decimals you can enter. It shouldn't be possible to enter more than three decimals.

image

Steps to Reproduce

  • Start registering a baker or update an existing pool.
  • When at the commission rate screen, try to enter more than three decimals, and notice how you can enter however many you like.

Expected Result

  • No more than three decimals

Actual Result

  • No limit on decimals

Versions

  • Software Version: 1.4.0-beta.2
  • OS: MacOS
  • Browser
  • Mobile device, if applicable
@jens-concordium jens-concordium added the [Type] Bug Something isn't working label May 6, 2022
@orhoj orhoj added the [Prio] Low Should be fixed if time permits but can be postponed. label May 9, 2022
@orhoj
Copy link
Contributor

orhoj commented May 9, 2022

This UI component will not be active on mainnet as the commission rates will be fixed. Therefore this is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Prio] Low Should be fixed if time permits but can be postponed. [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orhoj @jens-concordium