From f7b90b5e355a7e972bd24217f762a0d131c61a6f Mon Sep 17 00:00:00 2001 From: Alexander Day <55056986+AD417@users.noreply.github.com> Date: Sun, 19 Nov 2023 16:27:44 -0500 Subject: [PATCH 1/2] Prevent people from pinging @channel by submitting a Major Project with an @ sign --- conditional/blueprints/major_project_submission.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/conditional/blueprints/major_project_submission.py b/conditional/blueprints/major_project_submission.py index f8278d1..cc8619d 100644 --- a/conditional/blueprints/major_project_submission.py +++ b/conditional/blueprints/major_project_submission.py @@ -69,6 +69,10 @@ def submit_major_project(user_dict=None): return jsonify({"success": False}), 400 project = MajorProject(user_dict['username'], name, description) + # Don't you dare try pinging @channel + if "@" in name: + name = "@ ".join(name.split("@")) + username = user_dict['username'] send_slack_ping({"text":f" *{get_member_name(username)}* ({username})" f" submitted their major project, *{name}*!"}) From 1f43a32b80010c39da5fa82527d28baa4d9e064c Mon Sep 17 00:00:00 2001 From: Alexander Day <55056986+AD417@users.noreply.github.com> Date: Sun, 19 Nov 2023 16:51:01 -0500 Subject: [PATCH 2/2] Oh wait, it's not an @ sign --- conditional/blueprints/major_project_submission.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conditional/blueprints/major_project_submission.py b/conditional/blueprints/major_project_submission.py index cc8619d..431d9b7 100644 --- a/conditional/blueprints/major_project_submission.py +++ b/conditional/blueprints/major_project_submission.py @@ -70,8 +70,8 @@ def submit_major_project(user_dict=None): project = MajorProject(user_dict['username'], name, description) # Don't you dare try pinging @channel - if "@" in name: - name = "@ ".join(name.split("@")) + if " *{get_member_name(username)}* ({username})"