-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Expander on ListView + Enable Expander CollectionView GridLayout 1557 #1567
Conversation
It looks like this fix only targets Windows. I'm seeing similar broken behavior on iOS + MacCatalyst with a CollectionView inside Expander. Any chance you could take a look at the other platforms too? |
@brminnick as discussed at the meeting, I suggest merging it as it is (despite having some visual issues). |
@brminnick @VladislavAntonyuk Do you guys have any predictions on when this will be completed? We can see several people having exactly this expansion problem within the CollectionView, I think this would be a good time for that |
Thanks @VladislavAntonyuk for updating the expander under CollectionView and GridLayout. I just tested it on Android and it works as expected, however it does not work on macOS and iOS (see screenshot below):
On macOS/iOS, then you expand an item from the CollectionView all others disappear and it does not grow as expected. The same issue occurs on the horizontal items. I will see if I can help with the macOS/iOS issue :) |
@vhugogarcia has there been any progress made on this for iOS/macOS? I am currently stuck with it not working on iOS. |
samples/CommunityToolkit.Maui.Sample/Pages/Views/Expander/ExpanderPage.xaml
Outdated
Show resolved
Hide resolved
In android on bottom of page it expands as expected but fails to unexpand when clicked closed. It does remove image and text but the space is left open. 2025-02-04.07-57-23.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you have fixed the issue in windows and android with expander either failing to open properly(Windows) or failing to close properly(Android) I will be happy to approve this. It is looking very good and I can say I see no issues except the above.
thank you @ne0rrmatrix, I will take a look at Windows, because it looks broken. Android at least renders correctly and I don't want to change the default cell size maui behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ne0rrmatrix , that is not an issue, just scroll. it is a part of listview |
|
thank you. I will update docs and merge PR in the morning |
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information