Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Expander on ListView + Enable Expander CollectionView GridLayout 1557 #1567

Merged
merged 21 commits into from
Feb 5, 2025

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Nov 26, 2023

Linked Issues

PR Checklist

Additional information

image

image

@VladislavAntonyuk VladislavAntonyuk requested a review from a team November 26, 2023 19:06
@VladislavAntonyuk VladislavAntonyuk self-assigned this Nov 26, 2023
@TheCodeTraveler
Copy link
Collaborator

It looks like this fix only targets Windows. I'm seeing similar broken behavior on iOS + MacCatalyst with a CollectionView inside Expander.

Any chance you could take a look at the other platforms too?

@VladislavAntonyuk
Copy link
Collaborator Author

@brminnick as discussed at the meeting, I suggest merging it as it is (despite having some visual issues).

@ghost ghost added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Jan 15, 2024
@leoslima13
Copy link

@brminnick @VladislavAntonyuk Do you guys have any predictions on when this will be completed? We can see several people having exactly this expansion problem within the CollectionView, I think this would be a good time for that

@vhugogarcia
Copy link
Contributor

Thanks @VladislavAntonyuk for updating the expander under CollectionView and GridLayout.

I just tested it on Android and it works as expected, however it does not work on macOS and iOS (see screenshot below):

Android 1 macOS 2 iOS 3

On macOS/iOS, then you expand an item from the CollectionView all others disappear and it does not grow as expected. The same issue occurs on the horizontal items.

I will see if I can help with the macOS/iOS issue :)

@hayer
Copy link

hayer commented Mar 18, 2024

@vhugogarcia has there been any progress made on this for iOS/macOS? I am currently stuck with it not working on iOS.

@ne0rrmatrix
Copy link
Contributor

Looking good. One issue I am looking at in windows is:
image

As you can see the items at bottom are being cut off with no image being displayed. It is not scrollable at all and items expand maybe one inch or so.

@ne0rrmatrix ne0rrmatrix disabled auto-merge February 4, 2025 15:54
@ne0rrmatrix
Copy link
Contributor

In android on bottom of page it expands as expected but fails to unexpand when clicked closed. It does remove image and text but the space is left open.

2025-02-04.07-57-23.mp4

Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you have fixed the issue in windows and android with expander either failing to open properly(Windows) or failing to close properly(Android) I will be happy to approve this. It is looking very good and I can say I see no issues except the above.

@VladislavAntonyuk VladislavAntonyuk added area/views Issue/Discussion/PR that has to do with Views and removed help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days labels Feb 4, 2025
@VladislavAntonyuk
Copy link
Collaborator Author

thank you @ne0rrmatrix, I will take a look at Windows, because it looks broken. Android at least renders correctly and I don't want to change the default cell size maui behavior.

Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Window and android are working as expected now. On IOS there is one issue still.
Screenshot 2025-02-04 at 3 52 18 PM

@VladislavAntonyuk
Copy link
Collaborator Author

VladislavAntonyuk commented Feb 5, 2025

@ne0rrmatrix , that is not an issue, just scroll. it is a part of listview

@ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix , that is not an issue, just scroll. it is a part of listview
Yes I see that now. My bad. It looks good on my end and you have made all the requested changes.

@VladislavAntonyuk
Copy link
Collaborator Author

thank you. I will update docs and merge PR in the morning

@VladislavAntonyuk VladislavAntonyuk merged commit a6c11a2 into main Feb 5, 2025
10 checks passed
@VladislavAntonyuk VladislavAntonyuk deleted the 1557-fix-collectiobview branch February 5, 2025 20:44
@TheCodeTraveler TheCodeTraveler changed the title Expander CollectionView GridLayout 1557 Enable Expander on ListView (iOS) + Enable Expander CollectionView GridLayout 1557 Feb 6, 2025
@TheCodeTraveler TheCodeTraveler changed the title Enable Expander on ListView (iOS) + Enable Expander CollectionView GridLayout 1557 Enable Expander on ListView + Enable Expander CollectionView GridLayout 1557 Feb 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/views Issue/Discussion/PR that has to do with Views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Expander does not resize properly inside CollectionView
6 participants