Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded path for mediainfo #12

Open
micolous opened this issue Sep 20, 2021 · 0 comments
Open

Hard coded path for mediainfo #12

micolous opened this issue Sep 20, 2021 · 0 comments

Comments

@micolous
Copy link

There's a hard coded path to /usr/local/bin/mediainfo in autodetect_file.c:

char* mediaInfoInvokeStr = "/usr/local/bin/mediainfo";

As a result, if you have installed mediainfo in another directory that is in the PATH (eg: /usr/bin), such as installing it via apt install mediainfo, caption-inspector won't find it.

The Docker build appears to work around this by moving the binary:

COPY --from=base /usr/bin/mediainfo /usr/local/bin/mediainfo

The easy fix is to change this to:

char* mediaInfoInvokeStr = "mediainfo";

But it may also need a fix-up for the Docker container which puts the binary elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant