Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] lootbox_macros.cpp definitions prevents sqaudMarkers from adjusting squads with color names (sort of) #157

Closed
BAXENdev opened this issue Apr 18, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@BAXENdev
Copy link

lootbox_macros.hpp on lines 4-8 definitions collide with squad names that use fully capitalized colors in their names inside of squadMarkers.sqf.

For example:
In 3DEN editor, a squad is named "GREEN TEAM".
In squadMarkers.sqf, that squads definition would look like:

SET_SQUAD_IMPORTANT(GREEN TEAM,true);
SET_SQUAD_COLOUR(GREEN TEAM,COLOUR_GREEN);
SET_SQUAD_ICON(GREEN TEAM,ICON_MOTORINF);

Here, "GREEN" is caught by the "#define GREEN 20" on line 5 of lootbox_macros.hpp.

A simple workaround is to not use all caps. So bug doesnt critically break anything. It is just a hinder on naming squads by color in all caps, which is a very niche situation.

@BAXENdev BAXENdev added the bug Something isn't working label Apr 18, 2023
@Bubbus Bubbus added this to the 1.7.0 milestone Apr 18, 2023
@Bubbus
Copy link
Collaborator

Bubbus commented Apr 23, 2024

Will be resolved by #214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants