Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulate angles for all subsystems if decay does not have all subsystems #150

Open
redeboer opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Milestone

Comments

@redeboer
Copy link
Member

redeboer commented Jan 9, 2025

Since #127, amplitudes are only formulated for the subsystems that exist in a decay. This is okay for the amplitudes, but you may still want to have access to the angular distributions of the non-existent subsystsems. In AmpForm, this is done through HelicityAdapter.permutate_registered_topologies().

The solution probably lies here:

for sub_system in _get_subsystem_ids(self.decay):
chain_model = self.formulate_subsystem_amplitude(*args, sub_system) # type:ignore[arg-type]
amplitude_definitions.update(chain_model.amplitudes)
angle_definitions.update(chain_model.variables)
parameter_defaults.update(chain_model.parameter_defaults)

We would need a switch that allows calling angle_definitions.update(chain_model.variables) for sub_system in (1, 2, 3).

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Jan 9, 2025
@redeboer redeboer added this to the 0.2.2 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Development

No branches or pull requests

2 participants