Fix linker error on Windows with Intel oneAPI

Don't assume how to link `libm`, rely on CMake for it.

Fixes #5240

Author: al42and

CMakeLists.txt

@@ -522,8 +522,8 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "XL")
 endif()
 
 include(CheckLibraryExists)
-find_library(HAVE_LIBM m)
-mark_as_advanced(HAVE_LIBM)
+find_library(LIBM_LIBRARY m)
+mark_as_advanced(LIBM_LIBRARY)
 check_library_exists(rt clock_gettime "" HAVE_CLOCK_GETTIME)
 check_library_exists(m feenableexcept "" HAVE_FEENABLEEXCEPT)
 check_library_exists(m fedisableexcept "" HAVE_FEDISABLEEXCEPT)
@@ -893,8 +893,8 @@ if(HAVE_TIME_H AND HAVE_UNISTD_H AND HAVE_CLOCK_GETTIME)
 endif()
 
 # Math and thread libraries must often come after all others when linking...
-if (HAVE_LIBM)
-    list(APPEND GMX_PUBLIC_LIBRARIES m)
+if (LIBM_LIBRARY)
+    list(APPEND GMX_PUBLIC_LIBRARIES ${LIBM_LIBRARY})
 endif()
 
 option(GMX_NACL "Configure for Native Client builds" OFF)

cmake/FindFFTW.cmake

@@ -87,9 +87,9 @@ if (${FFTW}_FOUND)
   #The user could specify trash in ${FFTW}_LIBRARY, so test if we can link it
   include(CheckLibraryExists)
   include(gmxOptionUtilities)
-  if (HAVE_LIBM)
+  if (LIBM_LIBRARY)
     #adding MATH_LIBRARIES here to allow static libs, this does not harm us as we are anyway using it
-    set(CMAKE_REQUIRED_LIBRARIES m)
+    set(CMAKE_REQUIRED_LIBRARIES ${LIBM_LIBRARY})
   endif ()
   gmx_check_if_changed(FFTW_LIBRARY_CHANGED ${FFTW}_LIBRARIES)
   if (FFTW_LIBRARY_CHANGED)

docs/release-notes/2024/2024.5.rst

@@ -30,5 +30,14 @@ Handle trajectory reading error in gmx tcaf
 Fixes that affect portability
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+Fix linking error on Windows with Intel oneAPI
+""""""""""""""""""""""""""""""""""""""""""""""
+
+Fix ``LINK : fatal error LNK1181: cannot open input file ‘m.lib’``
+error encountered when using ``icx`` compiler on Windows by using
+dynamically-detected name for the ``m`` library.
+
+:issue:`5240`
+
 Miscellaneous
 ^^^^^^^^^^^^^