Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Path change/Drive change lead to create a directory that shouldn't exists #507

Open
cupang-afk opened this issue Jun 22, 2024 · 2 comments
Labels
Needs Triaging This issue needs the developer's attention to sort & prioritize.

Comments

@cupang-afk
Copy link

Affected Version

1.80.12

Bug Behavior

i found this when i try to use portable version of the launcher

using windows sandbox to simulate "moving to new pc" condition, and i got this problem

step i produce

  1. i take portable version in my F:\games
  2. i link/mount F:\games to the windows sandbox Desktop\portable
  3. doing first setup, select GameFolder location (Desktop\portable\GameFolder) and finish initialization (i choose genshin as my first setup)
  4. close windows sandbox
  5. change link/mount from Desktop\portable to Desktop\portable2
  6. repeat first setup, select the GameFolder again but now is in Desktop\portable2\GameFolder, and finish initialization (still choose genshin)
  7. and Desktop\portable\GameFolder is suddenly created

image

left is Desktop\portable2
right is Desktop\portable

my find is, GameFolder\GIGlb (potentialy all game version) has its own config.ini and there game_install_path is pointing to the absolute path of game data, in this case located in Desktop\portable instead of the new GameFolder location i choose from the second "first setup" (Desktop\portable2)

image

The Important

i dared to use those pre-setup GameFolder from the sandbox in my pc, and it create me the GameFolder i describe above
image

image

Expected Behavior

it should update the config.ini to use new GameData folder

OR

use relative path instead absolute path (i know it's already tracked in #79)

Steps to reproduce

Related Issues

No response

Screenshot(s)

No response

Additional Information

No response

@cupang-afk cupang-afk added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Jun 22, 2024
@bagusnl
Copy link
Member

bagusnl commented Jun 22, 2024

AFAIK the creation of the GiGlb folder in the old folder is due to the launcher still thought the path is in the portable folder as its saved in the GiGlb folder config so the launcher tries to resolve it. Removing this method might causes some errors/inconvenience in the time where Collapse is reinstalled in the same PC where the path did not changed.

Cc @neon-nyan

@cupang-afk
Copy link
Author

well the main use case for this problem is to be able to use collapse in portable mode so that i dont have to need to run the "first run", have my config pre-set up even if i change pc, and not creating directory like this

(i can imagine if i mount my drive as D: in one pc, and then move another pc it mount as F:, launcher will still create the GameFolder in D: and treat it as it was there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triaging This issue needs the developer's attention to sort & prioritize.
Projects
None yet
Development

No branches or pull requests

2 participants