Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add Checks before installing game for other files found #411

Open
Dark-talon opened this issue Mar 1, 2024 · 7 comments
Open

[Bug]: Add Checks before installing game for other files found #411

Dark-talon opened this issue Mar 1, 2024 · 7 comments
Labels
Area: Launcher Issue labeled for Launcher update mechanism Enhancement New feature or request

Comments

@Dark-talon
Copy link

Dark-talon commented Mar 1, 2024

Affected Version

1.73.4

Bug Behavior

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop.

Expected Behavior

It shouldnt be looking at anything outside of honkai 3rd impact assets!

Steps to reproduce

  1. Open Collapse
  2. Pick Honkai 3rd Impact - Region Global
  3. Click Game Repair Tab
  4. Run Quick Check

Related Issues

No response

Screenshot(s)

image

Additional Information

No response

@Dark-talon Dark-talon added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Mar 1, 2024
@Cactism
Copy link
Contributor

Cactism commented Mar 2, 2024

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

Recording.2024-03-01.203556.mp4

log-2024-03-01-pre1.73.4-id1.log

@bagusnl
Copy link
Member

bagusnl commented Mar 2, 2024

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

Recording.2024-03-01.203556.mp4

log-2024-03-01-pre1.73.4-id1.log

Crashing on small window is a known bug, will try to release a hotfix soon(tm)

@bagusnl bagusnl added Bug Something isn't working Area: UI/UX Issue labeled for User Interface/eXperience related issue and removed Needs Triaging This issue needs the developer's attention to sort & prioritize. labels Mar 2, 2024
@neon-nyan
Copy link
Member

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop.
It shouldnt be looking at anything outside of honkai 3rd impact assets!

Are you sure that you don't have any game files inside your game installation?
The folder contained by the game itself SHOULDN'T be mixed with other games.
Please make sure that you don't put your World of Warcraft besides the Honkai data (like, BH3_Data, BH3.exe, etc.)

@neon-nyan neon-nyan added Can't Reproduce Issue labeled for a bug that can't be reproduced by dev(s) and removed Bug Something isn't working Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Mar 2, 2024
@neon-nyan neon-nyan removed their assignment Mar 2, 2024
@neon-nyan
Copy link
Member

neon-nyan commented Mar 2, 2024

For me, trying to repair the game or update the cache outright crashes for me. :teri_rip: Using v1.73.4 Preview however.

Recording.2024-03-01.203556.mp4

log-2024-03-01-pre1.73.4-id1.log

Crashing on small window is a known bug, will try to release a hotfix soon(tm)

@bagusnl this issue isn't related with UI/UX issue. The first person who opened this issue was having the World of Warcraft installation inside the Honkai's folder.

Removing the assignment and unrelated tag

@neon-nyan
Copy link
Member

Also @Cactism,
Can you please open an new issue for the problem you are having with?
Just need to track of it.

@Dark-talon
Copy link
Author

Doing game repair for Honkai 3rd Impact is showing files for completely different games. This happened on both of my laptop and desktop.
It shouldnt be looking at anything outside of honkai 3rd impact assets!

Are you sure that you don't have any game files inside your game installation? The folder contained by the game itself SHOULDN'T be mixed with other games. Please make sure that you don't put your World of Warcraft besides the Honkai data (like, BH3_Data, BH3.exe, etc.)

Ugh... when I reinstalled HI3 with Collapse, I picked D:\Games\ expecting it to create the games folder like every single other installer in existence, instead it installed directly into it, so yes it makes sense now why the quick check was freaking out. The installer behavior should be changed imo in order to avoid this confusion for future people.

@neon-nyan
Copy link
Member

@Dark-talon,

Thank you for the confirmation.
For now, the launcher would install the game based on what the location is specified and doesn't create a new folder for it due to the same behaviour from Official Launcher.

But sure, We will consider this as an improvement plan in the future.

@neon-nyan neon-nyan added Enhancement New feature or request Area: Launcher Issue labeled for Launcher update mechanism and removed Can't Reproduce Issue labeled for a bug that can't be reproduced by dev(s) labels Mar 2, 2024
@bagusnl bagusnl changed the title [Bug]: Honkai 3rd Impact - Game Repair really broken [Bug]: Add Checks before installing game for other files found Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Launcher Issue labeled for Launcher update mechanism Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants