Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paintPartTile - render more at once ... #8163

Open
mmeeks opened this issue Feb 1, 2024 · 0 comments
Open

paintPartTile - render more at once ... #8163

mmeeks opened this issue Feb 1, 2024 · 0 comments
Assignees
Labels
24.04 enhancement New feature or request performance Improving COOL performance

Comments

@mmeeks
Copy link
Contributor

mmeeks commented Feb 1, 2024

Just checking out rendering of a fresh writer document load and I get:

kit-171319-171317 2024-02-01 18:29:23.857734 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7f2a97119010)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:23.900528 +0000 [ kitbroker_001 ] DBG  paintPartTile      12 tiles at (0, 0), (15360, 5120)  took 42791us (18.3784 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:23.903373 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 12 tiles at (0, 0), (15360, 5120)  took 45638us (17.232 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:23.903744 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ac9560)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:23.920972 +0000 [ kitbroker_001 ] DBG  paintPartTile      12 tiles at (0, 5120), (15360, 5120)  took 17226us (45.6538 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:23.923355 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 12 tiles at (0, 5120), (15360, 5120)  took 19611us (40.1016 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:23.923626 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ac9560)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:23.925435 +0000 [ kitbroker_001 ] DBG  paintPartTile      12 tiles at (0, 10240), (15360, 5120)  took 1807us (435.214 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:23.927877 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 12 tiles at (0, 10240), (15360, 5120)  took 4250us (185.043 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:23.928013 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ac9560)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:23.931279 +0000 [ kitbroker_001 ] DBG  paintPartTile      12 tiles at (0, 15360), (15360, 5120)  took 3264us (240.941 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:23.933952 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 12 tiles at (0, 15360), (15360, 5120)  took 5938us (132.441 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:24.248318 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7f2a96d9f010)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:24.253403 +0000 [ kitbroker_001 ] DBG  paintPartTile      16 tiles at (0, 0), (20480, 5120)  took 5083us (206.291 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:24.256520 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 16 tiles at (0, 0), (20480, 5120)  took 8201us (127.86 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:24.257436 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ea8120)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:24.263792 +0000 [ kitbroker_001 ] DBG  paintPartTile      16 tiles at (0, 5120), (20480, 5120)  took 6355us (165 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:24.267031 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 16 tiles at (0, 5120), (20480, 5120)  took 9594us (109.295 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:24.267336 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ea8120)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:24.269258 +0000 [ kitbroker_001 ] DBG  paintPartTile      16 tiles at (0, 10240), (20480, 5120)  took 1922us (545.565 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:24.272452 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 16 tiles at (0, 10240), (20480, 5120)  took 5114us (205.04 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:24.272726 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ea8120)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:24.275322 +0000 [ kitbroker_001 ] DBG  paintPartTile      16 tiles at (0, 15360), (20480, 5120)  took 2595us (404.076 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:24.278164 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 16 tiles at (0, 15360), (20480, 5120)  took 5437us (192.859 MP/s).| common/RenderTiles.hpp:372
kit-171319-171317 2024-02-01 18:29:24.278599 +0000 [ kitbroker_001 ] TRC  Calling paintPartTile(0x7ea8120)| common/RenderTiles.hpp:258
kit-171319-171317 2024-02-01 18:29:24.308548 +0000 [ kitbroker_001 ] DBG  paintPartTile      8 tiles at (0, 20480), (20480, 2560)  took 29946us (17.5078 MP/s).| common/RenderTiles.hpp:270
kit-171319-171317 2024-02-01 18:29:24.310881 +0000 [ kitbroker_001 ] DBG  paintPartTile+comp 8 tiles at (0, 20480), (20480, 2560)  took 32280us (16.2419 MP/s).| common/RenderTiles.hpp:372

which is interesting - it seems we don't render a full page before sending tiles back, despite that being contiguous - but we render in several bands down the page. It is possible that this saves memory, or improves latency, but - possibly it doesn't we should poke at the tuneables there to see what is going on I think =)

And I should push my updated timing instrumentation too I guess.

@mmeeks mmeeks added enhancement New feature or request performance Improving COOL performance 24.04 labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 enhancement New feature or request performance Improving COOL performance
Projects
Status: No status
Development

No branches or pull requests

2 participants